Issue 340059: Add support for for loops to the toplevel code generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340059: Add support for for loops to the toplevel code generator. (Closed)

Created:
11 years, 1 month ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
fschneider, William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add support for for loops to the toplevel code generator. Committed: http://code.google.com/p/v8/source/detail?r=3199

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -3 lines)			Patch
M	src/compiler.cc	View	2 chunks	+16 lines, -2 lines	1 comment	Download
M	src/fast-codegen.cc	View	2 chunks	+28 lines, -1 line	0 comments	Download
A	test/mjsunit/compiler/loops.js	View	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

http://codereview.chromium.org/340059/diff/1/3 File src/compiler.cc (right): http://codereview.chromium.org/340059/diff/1/3#newcode122 Line 122: if (FLAG_fast_compiler && !Bootstrapper::IsActive()) { I will not ...

11 years, 1 month ago (2009-11-02 14:01:22 UTC) #2

fschneider

LGTM. Nice to have it platform-independent. So much more compact!

11 years, 1 month ago (2009-11-02 14:05:49 UTC) #3

LGTM.

Expand Messages | Collapse Messages