Issue 340058: Add conditional expressions (ternary choice operator) to fast compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340058: Add conditional expressions (ternary choice operator) to fast compiler. (Closed)

Created:
11 years, 1 month ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add conditional expressions (ternary choice operator) to fast compiler. Committed: http://code.google.com/p/v8/source/detail?r=3192

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -2 lines)			Patch
	M	src/compiler.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	src/fast-codegen.cc	View		1 chunk	+30 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Tested on all platorms. Strangely, on ARM, the TestValue context seems not to be propagated ...

11 years, 1 month ago (2009-11-01 15:23:34 UTC) #1

Kevin Millikin (Chromium)

11 years, 1 month ago (2009-11-01 17:38:18 UTC) #2

LGTM.

We will want to consider how to manage the duplication of contexts here.  As you
note, it's a pessimization when the context does work.

As for ARM, I'm a little puzzled.  Did you have your implementation of unary NOT
merged in?  If not, you would get the optimizing compiler.

Expand Messages | Collapse Messages