Issue 340056: Moved +/i icon next to "Developer Tools" 2 px to the left, and made the text ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340056: Moved +/i icon next to "Developer Tools" 2 px to the left, and made the text ... (Closed)

Created:
11 years, 1 month ago by Ramkumar Ramachandra

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Moved +/i icon next to "Developer Tools" 2 px to the left, and made the text itself a link. BUG=26406 TEST=Compile and see chrome://extensions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30689

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/resources/extensions_ui.html	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

Thank you for this patch. http://codereview.chromium.org/340056/diff/1001/1002 File chrome/browser/resources/extensions_ui.html (right): http://codereview.chromium.org/340056/diff/1001/1002#newcode597 Line 597: <a onclick="toggleDeveloperTools();" href="#" ...

11 years, 1 month ago (2009-11-01 09:27:56 UTC) #2

Ramkumar Ramachandra

Right, thanks for pointing that out! It's fixed now.

11 years, 1 month ago (2009-11-01 11:14:08 UTC) #3

Committed as r30689. Thanks!

Expand Messages | Collapse Messages