String cleanup in sync code

chrome/browser/sync/syncable/directory_manager.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This used to do a lot of TLS-based management of multiple Directory objects.
 // We now can access Directory objects from any thread for general purpose
 // operations and we only ever have one Directory, so this class isn't doing
 // anything too fancy besides keeping calling and access conventions the same
 // for now.
 // TODO(timsteele): We can probably nuke this entire class and use raw
 // Directory objects everywhere.
 #ifndef CHROME_BROWSER_SYNC_SYNCABLE_DIRECTORY_MANAGER_H_
 #define CHROME_BROWSER_SYNC_SYNCABLE_DIRECTORY_MANAGER_H_
 
 #include <vector>
 
 #include "base/atomicops.h"
+#include "base/basictypes.h"
+#include "base/file_path.h"
 #include "base/lock.h"
-#include "base/basictypes.h"
 #include "chrome/browser/sync/syncable/dir_open_result.h"
 #include "chrome/browser/sync/syncable/path_name_cmp.h"
 #include "chrome/browser/sync/syncable/syncable.h"
 #include "chrome/browser/sync/util/event_sys.h"
 #include "chrome/browser/sync/util/sync_types.h"
 
 namespace sync_api { class BaseTransaction; }
 
 namespace syncable {
 
@@ skipping 13 matching lines @@
   }
 };
 
 DirectoryManagerEvent DirectoryManagerShutdownEvent();
 
 class DirectoryManager {
  public:
   typedef EventChannel<DirectoryManagerEvent> Channel;
 
   // root_path specifies where db is stored.
-  explicit DirectoryManager(const PathString& root_path);
+  explicit DirectoryManager(const FilePath& root_path);
   ~DirectoryManager();
 
-  static const PathString GetSyncDataDatabaseFilename();
-  const PathString GetSyncDataDatabasePath() const;
+  static const FilePath GetSyncDataDatabaseFilename();
+  const FilePath GetSyncDataDatabasePath() const;
 
   // Opens a directory.  Returns false on error.
   // Name parameter is the the user's login,
   // MUST already have been converted to a common case.
   bool Open(const PathString& name);
 
   // Marks a directory as closed.  It might take a while until all the
   // file handles and resources are freed by other threads.
   void Close(const PathString& name);
 
   // Should be called at App exit.
   void FinalSaveChangesForAll();
 
   // Gets the list of currently open directory names.
   typedef std::vector<PathString> DirNames;
   void GetOpenDirectories(DirNames* result);
 
   Channel* channel() const { return channel_; }
 
  protected:
-  DirOpenResult OpenImpl(const PathString& name, const PathString& path,
+  DirOpenResult OpenImpl(const PathString& name, const FilePath& path,
                          bool* was_open);
 
   // Helpers for friend class ScopedDirLookup:
   friend class ScopedDirLookup;
 
-  const PathString root_path_;
+  const FilePath root_path_;
 
   // protects managed_directory_
   Lock lock_;
   Directory* managed_directory_;
 
   Channel* const channel_;
 
  private:
 
   DISALLOW_COPY_AND_ASSIGN(DirectoryManager);
@@ skipping 20 matching lines @@
   bool good_;
   // Ensure that the programmer checks good before using the ScopedDirLookup.
   // This member should can be removed if it ever shows up in profiling
   bool good_checked_;
   DirectoryManager* const dirman_;
 };
 
 }  // namespace syncable
 
 #endif  // CHROME_BROWSER_SYNC_SYNCABLE_DIRECTORY_MANAGER_H_