Issue 340054: Correctly handle FTP servers which unexpectedly close the control connection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340054: Correctly handle FTP servers which unexpectedly close the control connection. (Closed)

Created:
11 years, 1 month ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
eroman, wtc

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Correctly handle FTP servers which unexpectedly close the control connection. TEST=Covered by net_unittests. BUG=25023 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30693

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -0 lines)			Patch
	M	net/ftp/ftp_network_transaction.cc	View		1 chunk	+8 lines, -0 lines	1 comment	Download
	M	net/ftp/ftp_network_transaction_unittest.cc	View		2 chunks	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

I'm not sure about the error code that should be returned. ERR_EMPTY_RESPONSE is not quite ...

11 years, 1 month ago (2009-10-31 10:16:58 UTC) #1

wtc

11 years, 1 month ago (2009-10-31 15:16:48 UTC) #2

LGTM.

http://codereview.chromium.org/340054/diff/1/2
File net/ftp/ftp_network_transaction.cc (right):

http://codereview.chromium.org/340054/diff/1/2#newcode531
Line 531: return Stop(ERR_EMPTY_RESPONSE);
I think ERR_EMPTY_RESPONSE is fine.  We can also add an
FTP error code for this condition (ERR_FTP_CONTROL_CONNECTION_CLOSED?).

Expand Messages | Collapse Messages