Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 340052: Clean up temp scaffolding stubs some. (Closed)

Created:
11 years, 1 month ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com, Paul Godavari, ben+cc_chromium.org
Visibility:
Public.

Description

Clean up temp scaffolding stubs some. It can be mac only now. BUG=9295, 8077 TEST=trybots

Patch Set 1 #

Patch Set 2 : chrome.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -133 lines) Patch
M chrome/browser/dom_ui/downloads_dom_handler.cc View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/dom_ui/downloads_ui.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/download/download_util.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/first_run.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/chrome.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/temp_scaffolding_stubs.h View 2 chunks +0 lines, -23 lines 0 comments Download
M chrome/common/temp_scaffolding_stubs.cc View 5 chunks +1 line, -87 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Evan Stade
11 years, 1 month ago (2009-10-30 23:27:01 UTC) #1
Evan Stade
see green try results on patch set 1 (which are actually results from runs of ...
11 years, 1 month ago (2009-10-30 23:28:24 UTC) #2
Evan Martin
11 years, 1 month ago (2009-10-31 02:42:19 UTC) #3
LGTM (i thought i got rid of this a few weeks ago?  i must have forgotten)

Make sure you don't break the views build.

Powered by Google App Engine
This is Rietveld 408576698