Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 340050: Add the plumbing and test code for plugins opening files from the sandbox. Th... (Closed)

Created:
11 years, 1 month ago by brettw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, jam, ben+cc_chromium.org, pam+watch_chromium.org, brettw+cc_chromium.org
Visibility:
Public.

Description

Add the plumbing and test code for plugins opening files from the sandbox. This does not implement the actual opening of the files (currently the chain ends in resource_message_filter.cc), I will do that separately with some additional security review. This current patch just gets the synchronous request to the browser and returns a NULL result. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30819

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -69 lines) Patch
M chrome/browser/renderer_host/resource_message_filter.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 2 3 chunks +20 lines, -2 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 2 chunks +24 lines, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.cc View 1 2 3 chunks +32 lines, -1 line 0 comments Download
M webkit/glue/pepper/pepper.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/glue/plugins/plugin_host.cc View 1 2 2 chunks +10 lines, -1 line 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl.h View 1 2 3 chunks +28 lines, -31 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl_mac.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl_win.cc View 1 2 5 chunks +17 lines, -16 lines 0 comments Download
M webkit/glue/webkitclient_impl.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M webkit/glue/webplugin_delegate.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/tools/pepper_test_plugin/plugin_object.cc View 1 2 5 chunks +22 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
11 years, 1 month ago (2009-10-30 22:24:38 UTC) #1
jam
lgtm http://codereview.chromium.org/340050/diff/15/1022 File chrome/browser/renderer_host/resource_message_filter.cc (right): http://codereview.chromium.org/340050/diff/15/1022#newcode1176 Line 1176: // note: when this is implemented, please ...
11 years, 1 month ago (2009-10-30 23:24:58 UTC) #2
darin (slow to review)
11 years, 1 month ago (2009-10-31 22:42:14 UTC) #3
what policy will we use for deciding what files to open in response to this IPC?
 (we don't want to allow the renderer to open any file, right?)

Powered by Google App Engine
This is Rietveld 408576698