Issue 340049: Extract webkit api target from webkit.gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340049: Extract webkit api target from webkit.gyp (Closed)

Created:
11 years, 1 month ago by yaar

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, dglazkov

Visibility:
Public.

Description

Extract webkit api target from webkit.gyp (in preparation for upstreaming the api) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30764

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+370 lines, -313 lines)			Patch
M	chrome/chrome.gyp	View	3 chunks	+3 lines, -3 lines	1 comment	Download
A	webkit/api/WebKitAPI.gyp	View	1 chunk	+363 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/webkit.gyp	View	3 chunks	+2 lines, -308 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 1 month ago (2009-11-02 18:10:29 UTC) #1

LGTM, except:

http://codereview.chromium.org/340049/diff/1/2
File chrome/chrome.gyp (right):

http://codereview.chromium.org/340049/diff/1/2#newcode4392
Line 4392: '../webkit/api/WebKitAPI.gyp:webkit_api',
just WebKit.gyp

Expand Messages | Collapse Messages