Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/cocoa/bookmark_bubble_controller.h

Issue 340042: bookmark STAR bubble: Disambiguate folders with the same name... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/cocoa/bookmark_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/bookmark_bubble_controller.h
===================================================================
--- chrome/browser/cocoa/bookmark_bubble_controller.h (revision 30683)
+++ chrome/browser/cocoa/bookmark_bubble_controller.h (working copy)
@@ -32,8 +32,8 @@
BookmarkModel* model_; // weak
const BookmarkNode* node_; // weak
- // A mapping from titles to nodes so we only have to walk this once.
- scoped_nsobject<NSMutableArray> titleMapping_;
+ // A mapping from NSComboBox index to parent nodes.
+ scoped_nsobject<NSMutableArray> parentMapping_;
BOOL alreadyBookmarked_;
scoped_nsobject<NSString> chooseAnotherFolder_;
@@ -71,6 +71,7 @@
- (void)addFolderNodes:(const BookmarkNode*)parent toComboBox:(NSComboBox*)box;
- (void)updateBookmarkNode;
- (void)setTitle:(NSString*)title parentFolder:(NSString*)folder;
+- (void)setParentFolderSelection:(const BookmarkNode*)parent;
- (NSString*)chooseAnotherFolderString;
- (NSComboBox*)folderComboBox;
@end
« no previous file with comments | « no previous file | chrome/browser/cocoa/bookmark_bubble_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698