Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: gypbuild.py

Issue 340038: Switch gypbuild to use devenv instead of msbuild.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/o3d/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gypbuild.py
===================================================================
--- gypbuild.py (revision 30366)
+++ gypbuild.py (working copy)
@@ -150,7 +150,7 @@
def CleanTargets(self, targets, options):
"""Cleans the targets."""
solution = self.GetSolutionPath()
- self.Execute(['devenv.exe',
+ self.Execute(['devenv.com',
solution,
'/clean',
options.version])
@@ -163,9 +163,15 @@
"or turn off UAC.\nAfter switching to admin run "
"'gclient runhooks --force'")
self.CheckVisualStudioVersionVsSolution(solution)
- self.Execute(['msbuild',
+ self.Execute(['devenv.com',
solution,
- '/p:Configuration=%s' % options.version])
+ '/build',
+ options.version])
+ # TODO(gman): Should I check for devenv and if it does not exist
+ # use msbuild? Msbuild is significantly slower than devenv.
+ #self.Execute(['msbuild',
+ # solution,
+ # '/p:Configuration=%s' % options.version])
class LinuxBuilder(Builder):
"""Class for building on Linux."""
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698