Initial pass of shared workers renderer-side code

Initial pass of shared workers renderer-side code

Added initial interface hooks betweek WebKit code and renderer-side worker code.
The proper messages are generated to fire off a shared worker, but they are currently
ignored by the browser process.

BUG=26233
TEST=none (will enable layout tests when basic functionality available)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30599

[Andrew T Wilson (Slow), 2009-10-29 21:44:35]

This patch contains the WebKit API additions and most of the renderer-side code
for creating SharedWorkers. I'll drive the browser/worker-proc side changes in a
separate patch.

[jam, 2009-10-29 22:50:53]

lgtm

http://codereview.chromium.org/340036/diff/2001/2002
File chrome/browser/in_process_webkit/browser_webkitclient_impl.cc (right):

http://codereview.chromium.org/340036/diff/2001/2002#newcode130
Line 130: return 0;
nit: Chrome style is to use NULL for pointers

http://codereview.chromium.org/340036/diff/2001/2005
File chrome/chrome.gyp (right):

http://codereview.chromium.org/340036/diff/2001/2005#newcode3275
Line 3275: 'renderer/renderer_websharedworkerrepository_impl.cc',
nit: since there's only one websharedworkerrepository_impl.cc, I think the
"renderer" at the front of the filename is not necessary

http://codereview.chromium.org/340036/diff/2001/2011
File chrome/renderer/renderer_websharedworkerrepository_impl.h (right):

http://codereview.chromium.org/340036/diff/2001/2011#newcode1
Line 1: // Copyright (c) 2009 The Chromium Authors. All rights reserved.  Use of
this
nit: just to double check, did you set svn:eol-style
to LF on all the new files?

[darin (slow to review), 2009-10-30 18:56:00]

http://codereview.chromium.org/340036/diff/2026/6019
File webkit/api/public/WebKitClient.h (right):

http://codereview.chromium.org/340036/diff/2026/6019#newcode228
Line 228: // Shared Workers
------------------------------------------------------
nit: should have two spaces above and one space below.  when in rome...

http://codereview.chromium.org/340036/diff/2026/6020
File webkit/api/public/WebSharedWorker.h (right):

http://codereview.chromium.org/340036/diff/2026/6020#newcode35
Line 35: #include "WebVector.h"
it looks like WebVector is not needed

http://codereview.chromium.org/340036/diff/2026/6020#newcode47
Line 47: virtual ~WebSharedWorker() {};
nit: no trailing ';'

http://codereview.chromium.org/340036/diff/2026/6020#newcode50
Line 50: // TODO(atwilson): Remove this when we move the initial script loading
into the worker process.
nit: TODO(foo) -> FIXME per webkit style

http://codereview.chromium.org/340036/diff/2026/6021
File webkit/api/public/WebSharedWorkerRepository.h (right):

http://codereview.chromium.org/340036/diff/2026/6021#newcode35
Line 35: #include "WebVector.h"
no need to include WebVector.h

http://codereview.chromium.org/340036/diff/2026/6021#newcode45
Line 45: typedef uintptr_t DocumentID;
as mentioned over IM, i don't think stddef.h is the proper include for
uintptr_t.  i'm referring to what WebCommon.h includes.

http://codereview.chromium.org/340036/diff/2026/6022
File webkit/api/src/SharedWorkerRepository.cpp (right):

http://codereview.chromium.org/340036/diff/2026/6022#newcode111
Line 111: // TODO(atwilson): Add code to check for a runtime flag like so:
this needs to be FIXME per webkit style

[John Gregg, 2009-10-30 19:09:22]

Piling on with more style nits I happened to notice...

http://codereview.chromium.org/340036/diff/2026/6022
File webkit/api/src/SharedWorkerRepository.cpp (right):

http://codereview.chromium.org/340036/diff/2026/6022#newcode63
Line 63: : m_worker(worker),
nit: webkit style is to line up ',' with ':', and i don't think the indentation
is right...

http://codereview.chromium.org/340036/diff/2026/6022#newcode87
Line 87: static WebMessagePortChannel* getWebPort(PassOwnPtr<MessagePortChannel>
port) {
nit: webkit style is '{' on own line for functions

http://codereview.chromium.org/340036/diff/2026/6022#newcode147
Line 147: WebKit::WebSharedWorkerRepository* repo =
WebKit::webKitClient()->sharedWorkerRepository();
you have a using WebKit::WebSharedWorkerRepository above so you don't need
WebKit:: prefix here

http://codereview.chromium.org/340036/diff/2026/6022#newcode154
Line 154: WebKit::WebSharedWorkerRepository* repo =
WebKit::webKitClient()->sharedWorkerRepository();
ditto