Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3227)

Unified Diff: chrome/browser/first_run.h

Issue 340020: Cleanup a few FirstRun methods that are only applicable to Windows. (Closed)
Patch Set: code review feedback" Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_main.cc ('k') | chrome/browser/first_run_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/first_run.h
diff --git a/chrome/browser/first_run.h b/chrome/browser/first_run.h
index e728d645020484b38c6e478cfecd0b399c18abe3..2f4ca92a801503b625beabff441902e9f482de50 100644
--- a/chrome/browser/first_run.h
+++ b/chrome/browser/first_run.h
@@ -28,30 +28,18 @@ class ProcessSingleton;
// install work for this user. After that the sentinel file is created.
class FirstRun {
public:
- // Returns true if this is the first time chrome is run for this user.
- static bool IsChromeFirstRun();
+#if defined(OS_WIN)
// Creates the desktop shortcut to chrome for the current user. Returns
// false if it fails. It will overwrite the shortcut if it exists.
static bool CreateChromeDesktopShortcut();
// Creates the quick launch shortcut to chrome for the current user. Returns
// false if it fails. It will overwrite the shortcut if it exists.
static bool CreateChromeQuickLaunchShortcut();
- // Creates the sentinel file that signals that chrome has been configured.
- static bool CreateSentinel();
- // Removes the sentinel file created in ConfigDone(). Returns false if the
- // sentinel file could not be removed.
- static bool RemoveSentinel();
- // Imports settings in a separate process. It spawns a second dedicated
- // browser process that just does the import with the import progress UI.
- static bool ImportSettings(Profile* profile, int browser_type,
- int items_to_import,
- gfx::NativeView parent_window);
// Import browser items in this process. The browser and the items to
// import are encoded int the command line. This function is paired with
// FirstRun::ImportSettings(). This function might or might not show
// a visible UI depending on the cmdline parameters.
static int ImportNow(Profile* profile, const CommandLine& cmdline);
-
// The master preferences is a JSON file with the same entries as the
// 'Default\Preferences' file. This function locates this file from
// master_pref_path or if that path is empty from the default location
@@ -74,6 +62,20 @@ class FirstRun {
bool* homepage_defined,
int* do_import_items,
int* dont_import_items);
+#endif // OS_WIN
+
+ // Returns true if this is the first time chrome is run for this user.
+ static bool IsChromeFirstRun();
+ // Creates the sentinel file that signals that chrome has been configured.
+ static bool CreateSentinel();
+ // Removes the sentinel file created in ConfigDone(). Returns false if the
+ // sentinel file could not be removed.
+ static bool RemoveSentinel();
+ // Imports settings in a separate process. It spawns a second dedicated
+ // browser process that just does the import with the import progress UI.
+ static bool ImportSettings(Profile* profile, int browser_type,
+ int items_to_import,
+ gfx::NativeView parent_window);
// Sets the kShouldShowFirstRunBubble local state pref so that the browser
// shows the bubble once the main message loop gets going. Returns false if
« no previous file with comments | « chrome/browser/browser_main.cc ('k') | chrome/browser/first_run_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698