Cleanup a few FirstRun methods that are only applicable to Windows.

Cleanup a few FirstRun methods that are only applicable to Windows.

BUG=11971
TEST=No functional change. Make sure first-run/import still works on all three platforms.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30379

[kuchhal, 2009-10-28 17:24:20]

Just cleanup of the functions that are only supposed to be implemented on
Windows.

[Evan Martin, 2009-10-28 17:28:05]

LGTM

http://codereview.chromium.org/340020/diff/1/2
File chrome/browser/browser_main.cc (right):

http://codereview.chromium.org/340020/diff/1/2#newcode509
Line 509: #endif
Maybe make this ifdef wrap the definition and usage of first_run_tabs as well? 
From L501 through L513?

http://codereview.chromium.org/340020/diff/1/2#newcode647
Line 647: return FirstRun::ImportNow(profile, parsed_command_line);
Doesn't Mac use this too?

[kuchhal, 2009-10-28 17:45:39]

>
> Maybe make this ifdef wrap the definition and usage of first_run_tabs as
> well?  From L501 through L513?
>

Done.


>
> http://codereview.chromium.org/340020/diff/1/2#newcode647
> Line 647: return FirstRun::ImportNow(profile, parsed_command_line);
> Doesn't Mac use this too?


It was stubbed out in temp_scaffolding for Mac.

Jeremy, can you take a quick look?

[Evan Martin, 2009-10-28 17:47:41]

On Wed, Oct 28, 2009 at 10:44 AM, Rahul Kuchhal <kuchhal@chromium.org> wrote:
>> http://codereview.chromium.org/340020/diff/1/2#newcode647
>> Line 647: return FirstRun::ImportNow(profile, parsed_command_line);
>> Doesn't Mac use this too?
>
> It was stubbed out in temp_scaffolding for Mac.
> Jeremy, can you take a quick look?

Oh yeah, hrm.  I thought mac did OOP import, thought it might need that code.

[jeremy, 2009-10-28 20:02:50]

LGTM

Thanks for the cleanup!!

http://codereview.chromium.org/340020/diff/4001/3002
File chrome/browser/browser_main.cc (right):

http://codereview.chromium.org/340020/diff/4001/3002#newcode512
Line 512: #endif
// OS_WIN

http://codereview.chromium.org/340020/diff/4001/3003
File chrome/browser/first_run.h (right):

http://codereview.chromium.org/340020/diff/4001/3003#newcode65
Line 65: #endif
// OS_WIN