Issue 340018: Filter out hidden files, both when loading extensions and when

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340018: Filter out hidden files, both when loading extensions and when (Closed)

Created:
11 years, 1 month ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
rafaelw

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Filter out hidden files, both when loading extensions and when packaging them. We also special case the common OS X zip dropping "__MACOSX" when loading extensions. BUG=23004 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30312

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -11 lines)			Patch
M	chrome/browser/extensions/extension_creator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_file_util.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/zip.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/common/zip.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/common/zip_unittest.cc	View	4 chunks	+33 lines, -9 lines	0 comments	Download
	chrome/test/data/zip/test.zip	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/test/data/zip/test/foo/bar/.hidden	View	1 chunk	+1 line, -0 lines	0 comments	Download
	chrome/test/data/zip/test_nocompress.zip	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 3 (0 generated)

lgtm