Issue 340016: Spoof UA as Chrome 1.0 when loading URLs from *.pointroll.com.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 340016: Spoof UA as Chrome 1.0 when loading URLs from *.pointroll.com. (Closed)

Created:
11 years, 1 month ago by dglazkov

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review), Peter Kasting

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Spoof UA as Chrome 1.0 when loading URLs from *.pointroll.com. BUG=25934 TEST=none R=darin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30306

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Total comments: 1

Patch Set 3 : Nits addressed, good to go. #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -8 lines)			Patch
	M	webkit/glue/webkit_glue.cc	View	1 2	6 chunks	+26 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 1 month ago (2009-10-27 23:12:34 UTC) #3

LGTM modulo one nit:

http://codereview.chromium.org/340016/diff/2001/3001
File webkit/glue/webkit_glue.cc (right):

http://codereview.chromium.org/340016/diff/2001/3001#newcode72
Line 72: static const std::string kChrome1ProductString = "Chrome/1.0.154.53";
nit: no static std::string

Expand Messages | Collapse Messages