[Mac] Makes the download shelf auto-close after the user opens all downloads...

[Mac] Makes the download shelf auto-close after the user opens all downloads
and moves mouse off the shelf.

This is the mac implementation of r57541.

BUG=55413
TEST=Download an item, open it, move the mouse off the download shelf and make sure it closes.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69718

[Nico, 2010-09-28 18:12:29]

http://codereview.chromium.org/3400027/diff/5001/6006
File chrome/browser/cocoa/download_shelf_controller.mm (right):

http://codereview.chromium.org/3400027/diff/5001/6006#newcode43
chrome/browser/cocoa/download_shelf_controller.mm:43: // even if that download
was never actually clicked on and opened.
Is there some way to have this logic (and this comment) in the model code
instead of in all the different view code?

[rohitrao (ping after 24h), 2010-09-28 19:12:59]

http://codereview.chromium.org/3400027/diff/5001/6006
File chrome/browser/cocoa/download_shelf_controller.mm (right):

http://codereview.chromium.org/3400027/diff/5001/6006#newcode43
chrome/browser/cocoa/download_shelf_controller.mm:43: // even if that download
was never actually clicked on and opened.
On 2010/09/28 18:12:29, Nico wrote:
> Is there some way to have this logic (and this comment) in the model code
> instead of in all the different view code?

I don't think there's a suitable cross-platform class that can handle this. 
Unless I'm mistaken, the view code holds the list of download items, since
there's no C++ shelf object.

[Nico, 2010-09-29 15:52:45]

http://codereview.chromium.org/3400027/diff/5001/6006
File chrome/browser/cocoa/download_shelf_controller.mm (right):

http://codereview.chromium.org/3400027/diff/5001/6006#newcode43
chrome/browser/cocoa/download_shelf_controller.mm:43: // even if that download
was never actually clicked on and opened.
On 2010/09/28 19:12:59, rohitrao wrote:
> On 2010/09/28 18:12:29, Nico wrote:
> > Is there some way to have this logic (and this comment) in the model code
> > instead of in all the different view code?
> 
> I don't think there's a suitable cross-platform class that can handle this. 
> Unless I'm mistaken, the view code holds the list of download items, since
> there's no C++ shelf object.

Should there be one?

[rohitrao (ping after 24h), 2010-10-01 03:41:57]

Scott, what do you think?  Is there enough shared code to warrant creating a
cross-platform shelf object?

On 2010/09/29 15:52:45, Nico wrote:
> http://codereview.chromium.org/3400027/diff/5001/6006
> File chrome/browser/cocoa/download_shelf_controller.mm (right):
> 
> http://codereview.chromium.org/3400027/diff/5001/6006#newcode43
> chrome/browser/cocoa/download_shelf_controller.mm:43: // even if that download
> was never actually clicked on and opened.
> On 2010/09/28 19:12:59, rohitrao wrote:
> > On 2010/09/28 18:12:29, Nico wrote:
> > > Is there some way to have this logic (and this comment) in the model code
> > > instead of in all the different view code?
> > 
> > I don't think there's a suitable cross-platform class that can handle this. 
> > Unless I'm mistaken, the view code holds the list of download items, since
> > there's no C++ shelf object.
> 
> Should there be one?

[sky, 2010-10-01 17:06:02]

The model is the download items. I'm inclined to think that is the best thing to
share and we should stick with what we have. That said, Nico, if you have ideas
please refactor.

  -Scott

On 2010/10/01 03:41:57, rohitrao wrote:
> Scott, what do you think?  Is there enough shared code to warrant creating a
> cross-platform shelf object?
> 
> On 2010/09/29 15:52:45, Nico wrote:
> > http://codereview.chromium.org/3400027/diff/5001/6006
> > File chrome/browser/cocoa/download_shelf_controller.mm (right):
> > 
> > http://codereview.chromium.org/3400027/diff/5001/6006#newcode43
> > chrome/browser/cocoa/download_shelf_controller.mm:43: // even if that
download
> > was never actually clicked on and opened.
> > On 2010/09/28 19:12:59, rohitrao wrote:
> > > On 2010/09/28 18:12:29, Nico wrote:
> > > > Is there some way to have this logic (and this comment) in the model
code
> > > > instead of in all the different view code?
> > > 
> > > I don't think there's a suitable cross-platform class that can handle
this. 
> > > Unless I'm mistaken, the view code holds the list of download items, since
> > > there's no C++ shelf object.
> > 
> > Should there be one?

[rohitrao (ping after 24h), 2010-10-08 20:30:04]

I guess this is back to Nico for another look then.  Because, you know, he's not
busy with anything else.

On 2010/10/01 17:06:02, sky wrote:
> The model is the download items. I'm inclined to think that is the best thing
to
> share and we should stick with what we have. That said, Nico, if you have
ideas
> please refactor.
> 
>   -Scott

[Nico, 2010-12-12 22:03:19]

LG

http://codereview.chromium.org/3400027/diff/5001/chrome/browser/cocoa/downloa...
File chrome/browser/cocoa/download_shelf_controller.mm (right):

http://codereview.chromium.org/3400027/diff/5001/chrome/browser/cocoa/downloa...
chrome/browser/cocoa/download_shelf_controller.mm:29: // The download shelf
autocloses if all of:
"if all this is true:"

http://codereview.chromium.org/3400027/diff/5001/chrome/browser/cocoa/downloa...
chrome/browser/cocoa/download_shelf_controller.mm:62: const NSTimeInterval
kAutoCloseDelay = 5;
kAutoCloseDelaySeconds

[rohitrao (ping after 24h), 2010-12-20 16:58:02]

Fixed the nits and committed.  Thanks for the review!