Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 3400014: Merge 67292 - 2010-09-11 Mihai Parparita <mihaip@chromium.org>... (Closed)

Created:
10 years, 3 months ago by tonyg
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/517/
Visibility:
Public.

Description

Merge 67292 - 2010-09-11 Mihai Parparita <mihaip@chromium.org>; Reviewed by Adam Barth. URIs in styles created via innerHTML are not resolved against the document's base URI https://bugs.webkit.org/show_bug.cgi?id=45565 Add test to read back the background image URL from an element that was created via innerHTML (reduction of http://crbug.com/55023). * fast/innerHTML/innerHTML-uri-resolution-expected.txt: Added. * fast/innerHTML/innerHTML-uri-resolution.html: Added. 2010-09-11 Mihai Parparita <mihaip@chromium.org>; Reviewed by Adam Barth. URIs in styles created via innerHTML are not resolved against the document's base URI https://bugs.webkit.org/show_bug.cgi?id=45565 The dummy document used for fragment parsing created by FragmentParsingContext should use the base URI of the fragment's document. Since (HTML)Document doesn't expose a setter for the base URI (and shouldn't), we allow it to be set by the constructor/create function. Also remove some obsolete code that references the legacy tree builder from HTMLElement that I happened to notice. Test: fast/innerHTML/innerHTML-uri-resolution.html * dom/Document.cpp: (WebCore::Document::Document): * dom/Document.h: * html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): * html/HTMLDocument.h: (WebCore::HTMLDocument::create): * html/HTMLElement.cpp: (WebCore::createFragmentFromSource): (WebCore::HTMLElement::setInnerHTML): * html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): BUG=56034 TBR=mihaip@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67732

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10984 lines, -36 lines) Patch
M LayoutTests/ChangeLog View 3 chunks +6270 lines, -0 lines 0 comments Download
A + LayoutTests/fast/innerHTML/innerHTML-uri-resolution.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/innerHTML/innerHTML-uri-resolution-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M WebCore/ChangeLog View 6 chunks +4703 lines, -10 lines 0 comments Download
M WebCore/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M WebCore/dom/Document.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M WebCore/html/HTMLDocument.h View 2 chunks +3 lines, -3 lines 0 comments Download
M WebCore/html/HTMLDocument.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M WebCore/html/HTMLElement.cpp View 3 chunks +0 lines, -20 lines 0 comments Download
M WebCore/html/parser/HTMLTreeBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tonyg
10 years, 3 months ago (2010-09-17 18:38:00 UTC) #1
Mihai Parparita -not on Chrome
10 years, 3 months ago (2010-09-17 19:44:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698