Issue 3399005: Add a few missing nops to signal no inlined code was generated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3399005: Add a few missing nops to signal no inlined code was generated. (Closed)

Created:
10 years, 3 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Visibility:
Public.

Add a few missing nops to signal no inlined code was generated. Committed: http://code.google.com/p/v8/source/detail?r=5454

Created: 10 years, 3 months ago

		Unified diffs	Side-by-side diffs	Stats (+5 lines, -1 line)
	M	src/ia32/full-codegen-ia32.cc	View	3 chunks	+3 lines, -1 line	0 comments
	M	src/x64/full-codegen-x64.cc	View	2 chunks	+2 lines, -0 lines	0 comments

Total messages: 2 (0 generated)

Vyacheslav Egorov (Chromium)

10 years, 3 months ago (2010-09-14 16:27:53 UTC) #2

LGTM

but please add a comment above this nop() like done in other places.