Issue 3398011: AU: Mix stdout and stderr together in the logs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3398011: AU: Mix stdout and stderr together in the logs. (Closed)

Created:
10 years, 3 months ago by Kenneth Waters

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

AU: Mix stdout and stderr together in the logs. BUG=none TEST=Updated on tegra2_dev-board Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a7fcafa

Patch Set 1 #

Total comments: 2

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
	M	subprocess.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	subprocess.cc	View		3 chunks	+9 lines, -7 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kenneth Waters

http://codereview.chromium.org/3398011/diff/1/2 File subprocess.cc (right): http://codereview.chromium.org/3398011/diff/1/2#newcode147 subprocess.cc:147: LOG(INFO) << "Subprocess output:\n" << child_stdout; Do we need ...

10 years, 3 months ago (2010-09-17 20:08:28 UTC) #2

adlr

10 years, 3 months ago (2010-09-17 20:16:27 UTC) #3

LGTM

http://codereview.chromium.org/3398011/diff/1/2
File subprocess.cc (right):

http://codereview.chromium.org/3398011/diff/1/2#newcode147
subprocess.cc:147: LOG(INFO) << "Subprocess output:\n" << child_stdout;
On 2010/09/17 20:08:28, Kenneth Waters wrote:
> Do we need to call "g_free(child_stdout)" here ?

ask valgrind?

Expand Messages | Collapse Messages