Issue 3398008: Directly hook sys.stdout for thread annotated output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3398008: Directly hook sys.stdout for thread annotated output. (Closed)

Created:
10 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Directly hook sys.stdout for thread annotated output. In the next change, we can now remove all the options.stdout bookeeping since it's not unnecessary. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59795

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix small errors, smoke tests rock. #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -30 lines)			Patch
M	gclient.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	gclient_utils.py	View	1	5 chunks	+70 lines, -27 lines	0 comments	Download
M	tests/gclient_utils_test.py	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bradn

LGTM http://codereview.chromium.org/3398008/diff/1/3 File gclient_utils.py (right): http://codereview.chromium.org/3398008/diff/1/3#newcode338 gclient_utils.py:338: """Creates a file object clone to automatically prepends ...

10 years, 3 months ago (2010-09-16 22:44:12 UTC) #2

M-A Ruel

http://codereview.chromium.org/3398008/diff/1/3 File gclient_utils.py (right): http://codereview.chromium.org/3398008/diff/1/3#newcode338 gclient_utils.py:338: """Creates a file object clone to automatically prepends every ...

10 years, 3 months ago (2010-09-17 15:13:22 UTC) #3

bradn

10 years, 3 months ago (2010-09-17 17:04:12 UTC) #4

No I meant I believe the style guide wants the description to be one line.
Brevity, souls, and wit and all that.

Expand Messages | Collapse Messages