Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2147)

Unified Diff: WebKit/chromium/src/WebAccessibilityCacheImpl.cpp

Issue 3398006: Merge 67418 - 2010-09-13 Chris Guillory <chris.guillory@google.com>... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/517/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « WebKit/chromium/public/WebAccessibilityObject.h ('k') | WebKit/chromium/src/WebAccessibilityObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: WebKit/chromium/src/WebAccessibilityCacheImpl.cpp
===================================================================
--- WebKit/chromium/src/WebAccessibilityCacheImpl.cpp (revision 67507)
+++ WebKit/chromium/src/WebAccessibilityCacheImpl.cpp (working copy)
@@ -63,7 +63,6 @@
PassRefPtr<WebAccessibilityCacheImpl::WeakHandle> WebAccessibilityCacheImpl::WeakHandle::create(AccessibilityObject* object)
{
- // FIXME: Remove resetting ref-count from AccessibilityObjectWrapper
RefPtr<WebAccessibilityCacheImpl::WeakHandle> weakHandle = adoptRef(new WebAccessibilityCacheImpl::WeakHandle(object));
weakHandle->m_object->setWrapper(weakHandle.get());
@@ -149,7 +148,7 @@
int WebAccessibilityCacheImpl::addOrGetId(const WebAccessibilityObject& object)
{
- if (object.isNull())
+ if (!object.isValid())
return invalidObjectId;
RefPtr<AccessibilityObject> o = toAccessibilityObject(object);
« no previous file with comments | « WebKit/chromium/public/WebAccessibilityObject.h ('k') | WebKit/chromium/src/WebAccessibilityObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698