Issue 3398004: Linux Reliability: Strip test binaries and libraries....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3398004: Linux Reliability: Strip test binaries and libraries.... (Closed)

Created:
10 years, 3 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Michael Moss

CC:
chromium-reviews, Allen

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux Reliability: Strip test binaries and libraries. BUG=none TEST=Linux Reliability Builder test directory output is < 100 MB. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59569

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	build/common.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/chrome.gyp	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Moss

LGTM with syntax nit. http://codereview.chromium.org/3398004/diff/1/3 File chrome/chrome.gyp (right): http://codereview.chromium.org/3398004/diff/1/3#newcode1578 chrome/chrome.gyp:1578: '<(PRODUCT_DIR)/lib.target/_pyautolib.so'], Maybe use '<@(_inputs)' here.

10 years, 3 months ago (2010-09-14 19:14:16 UTC) #2

Lei Zhang

10 years, 3 months ago (2010-09-15 22:24:25 UTC) #3

On 2010/09/14 19:14:16, Michael Moss wrote:
> LGTM with syntax nit.
> 
> http://codereview.chromium.org/3398004/diff/1/3
> File chrome/chrome.gyp (right):
> 
> http://codereview.chromium.org/3398004/diff/1/3#newcode1578
> chrome/chrome.gyp:1578: '<(PRODUCT_DIR)/lib.target/_pyautolib.so'],
> Maybe use '<@(_inputs)' here.

Done.

Expand Messages | Collapse Messages