Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 3398002: Add "task" to ibus.conf since the file no longer launches ibus-daemon. (Closed)

Created:
10 years, 3 months ago by Yusuke Sato
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone
CC:
chromium-os-reviews_chromium.org, Zachary Kuznia, Peng
Base URL:
ssh://git@chromiumos-git//init.git
Visibility:
Public.

Description

Add "task" to ibus.conf since the file no longer launches ibus-daemon. Please note that we have decided to kill ibus daemons in ibus.conf rather than session_manager since it turned out that Chrome and ibus daemons can't have the same process group id. Please check the issue 6515 for details. BUG=chromium-os:6515 TEST=manually tested. see the bug.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M ibus.conf View 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yusuke Sato
10 years, 3 months ago (2010-09-14 10:20:31 UTC) #1
Chris Masone
10 years, 3 months ago (2010-09-14 14:51:57 UTC) #2
LGTM

On Tue, Sep 14, 2010 at 3:20 AM, <yusukes@chromium.org> wrote:

> Reviewers: Chris Masone,
>
> Description:
> Add "task" to ibus.conf since the file no longer launches ibus-daemon.
>
> Please note that we have decided to kill ibus daemons in ibus.conf rather
> than
> session_manager since it turned out that Chrome and ibus daemons can't have
> the
> same process group id. Please check the issue 6515 for details.
>
> BUG=chromium-os:6515
> TEST=manually tested. see the bug.
>
> Please review this at http://codereview.chromium.org/3398002/show
>
> SVN Base: ssh://git@chromiumos-git//init.git
>
> Affected files:
>  M ibus.conf
>
>
> Index: ibus.conf
> diff --git a/ibus.conf b/ibus.conf
> index
>
2af29123c4d7d5c183d6cb04f8c66a2944f0dd91..53212be376ea5f630c7475ef236ece00151f50e5
> 100644
> --- a/ibus.conf
> +++ b/ibus.conf
> @@ -2,27 +2,28 @@
>  # Use of this source code is governed by a BSD-style license that can be
>  # found in the LICENSE file.
>
> -description   "Run ibus-daemon and ibus-memconf"
> +description   "Kill input method daemons when X stopped"
>  author        "chromium-os-dev@googlegroups.com"
>
> -stop on stopping ui
> +start on stopping ui
> +task
>
>  # ibus-daemon creates a temporary file in /home/chronos,
>  # not in /home/chronos/user.
>  env HOME=/home/chronos
>
> -post-stop script
> +script
>
>  set +e
>  . /sbin/killers
>
> -# Ensure ibus-daemon  and sub-processes are terminated. Note that these
> -# processes are not mananged by Upstart.
> -term_process "(candidate_w.*|ibus-[dem].*)"
> +# Ensure candidate_window for input methods, ibus-daemon, and sub
> processes
> +# of ibus-daemon are terminated. Note that candidate_window and IBus
> processes
> +# are not mananged by Upstart. They are launched from Chrome. ".*" is used
> +# since the process name used for matching is limited to 15 characters.
> +term_process "(candidate_w.*|ibus-.*)"
>
> -# Since Chrome OS regenerates /var/lib/dbus/machine-id every time when the
> OS
> -# starts, ibus-daemon creates a new file in ${HOME}/.config/ibus/bus/
> every time
> -# when it starts. It's better to remove them when ibus-daemon is
> terminated.
> +# Remove ibus-daemon's PID file.
>  rm -f ${HOME}/.config/ibus/bus/*
>
>  end script
>
>
>

Powered by Google App Engine
This is Rietveld 408576698