Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 3397028: Hide "Change proxy settings link" during connection in progress. (Closed)

Created:
10 years, 3 months ago by Denis Lagno
Modified:
9 years, 6 months ago
Reviewers:
whywhat
CC:
chromium-reviews, dhg, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Hide "Change proxy settings link" during connection in progress. Replace chrome://options with chrome://settings because it was changed recently. BUG=None TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/chromeos/login/network_selection_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/options_ui.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Denis Lagno
please take a look
10 years, 3 months ago (2010-09-24 14:19:03 UTC) #1
whywhat
10 years, 3 months ago (2010-09-24 14:23:06 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698