Issue 3397003: Replace a data file used in download tests with a much smaller one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3397003: Replace a data file used in download tests with a much smaller one. (Closed)

Created:
10 years, 3 months ago by Nirnimesh

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews, Paweł Hajdan Jr.

Visibility:
Public.

Replace a data file used in download tests with a much smaller one. The dmg used need not be a valid one. Replacing the 10MB one with a 4K one. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59604

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch
	chrome/test/data/downloads/dangerous/dangerous.dmg	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	chrome/test/data/downloads/dangerous/invalid-dummy.dmg	View	2	Binary file		0 comments	Download
M	chrome/test/functional/downloads.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

John Grabowski

10 years, 3 months ago (2010-09-16 01:21:57 UTC) #3

Possibly rename this invalid-dummy.dmg in case someone tries to write a test
which assumes otherwise.

LGTM