Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 3396029: Flesh out URLLoader's download_to_file function.... (Closed)

Created:
10 years, 2 months ago by michaeln
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, dpranke+watch_chromium.org, ben+cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Flesh out URLLoader's download_to_file function. * tie the lifetime of the resulting temp file to the lifetime of the URLLoader (the plan is to later extend the lifetime of the temp file to support xhr.responseBlob) * make it work in test_shell * make it work for sync requests * added OnDataDownloaded messages to report progress A related BlobURL loading change. * grab a reference to the blob early on to ensure it's still there when the 'job' is finally started. TEST=manual and deletable_file_reference_unittest.cc BUG=52486, 56752 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60862

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Total comments: 2

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+466 lines, -116 lines) Patch
M chrome/browser/net/blob_url_request_job_factory.cc View 1 2 3 4 5 6 2 chunks +15 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/async_resource_handler.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/renderer_host/async_resource_handler.cc View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/redirect_to_file_resource_handler.h View 1 2 3 4 5 6 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/redirect_to_file_resource_handler.cc View 1 2 3 4 5 6 6 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.h View 1 2 3 4 5 6 4 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 1 2 3 4 5 6 10 chunks +47 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_request_info.h View 1 2 3 4 5 6 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_request_info.cc View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_handler.h View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/sync_resource_handler.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 2 3 4 5 6 4 chunks +15 lines, -12 lines 0 comments Download
M chrome/common/resource_dispatcher.h View 1 2 3 4 5 6 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/common/resource_dispatcher.cc View 1 2 3 4 5 6 9 chunks +74 lines, -75 lines 0 comments Download
A webkit/blob/deletable_file_reference.h View 1 chunk +49 lines, -0 lines 0 comments Download
A webkit/blob/deletable_file_reference.cc View 1 chunk +63 lines, -0 lines 0 comments Download
A webkit/blob/deletable_file_reference_unittest.cc View 1 2 3 4 5 1 chunk +54 lines, -0 lines 0 comments Download
M webkit/blob/webkit_blob.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/weburlloader_impl.cc View 1 2 3 4 5 6 2 chunks +5 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/simple_resource_loader_bridge.cc View 1 2 3 4 5 6 15 chunks +53 lines, -3 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
michaeln
Same patch as before (http://codereview.chromium.org/3165062/show) with the changes described here... > Per http://code.google.com/p/chromium/issues/detail?id=56752... > > ...
10 years, 2 months ago (2010-09-28 02:32:04 UTC) #1
darin (slow to review)
LGTM
10 years, 2 months ago (2010-09-28 06:14:41 UTC) #2
Paweł Hajdan Jr.
Drive-by with a test comment. Please make a follow-up CL. http://codereview.chromium.org/3396029/diff/26002/17022 File webkit/blob/deletable_file_reference_unittest.cc (right): http://codereview.chromium.org/3396029/diff/26002/17022#newcode20 ...
10 years, 2 months ago (2010-09-28 08:42:15 UTC) #3
michaeln
http://codereview.chromium.org/3396029/diff/26002/17022 File webkit/blob/deletable_file_reference_unittest.cc (right): http://codereview.chromium.org/3396029/diff/26002/17022#newcode20 webkit/blob/deletable_file_reference_unittest.cc:20: file_util::CreateTemporaryFile(&file); On 2010/09/28 08:42:15, Paweł Hajdan Jr. wrote: > ...
10 years, 2 months ago (2010-09-28 19:09:23 UTC) #4
Paweł Hajdan Jr.
10 years, 2 months ago (2010-09-29 08:43:16 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698