Issue 3396021: Fix bug where install animation would replay if something on the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3396021: Fix bug where install animation would replay if something on the (Closed)

Created:
10 years, 3 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Fix bug where install animation would replay if something on the same page was uninstalled. BUG=56454 TEST=Install one app, then another. Uninstall the first one. Second one's install animation should not replay. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60391

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -3 lines)			Patch
M	chrome/browser/resources/new_new_tab.html	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/ntp/apps.css	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/ntp/apps.js	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

10 years, 3 months ago (2010-09-24 00:04:44 UTC) #2

LGTM

You could also use an empty attribute value and remove the attribute when done.

<html enabled>

html[enabled] #foo { ... }

Expand Messages | Collapse Messages