Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 3396005: Fixes for a couple of ChromeFrame crashes seen in the latest dev channel buil... (Closed)

Created:
10 years, 3 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Fixes for a couple of ChromeFrame crashes seen in the latest dev channel build. These crashes occur in the Chrome HTTP stack which is used for uploading UMA data. I could not repro these crashes though and they seem to occur while posting tasks to a deleted message loop. Currently we create an io thread on the fly for uploading the uma data and destroy it when we are done. To workaround this issue we are attempting to create one IO thread and leave it running. At this point this thread object is leaked as we don't have a good way of stopping this from the IO thread. Added a TODO in the code to this effect. I also added a check for whether the ChromeFrameMetricsDataUploader::Initialize function succeeds as it appears that there are failures on the field due to failure in creating the unnamed window. The ChromeFrame metrics service object is no longer a ThreadLocal object. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59594

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -25 lines) Patch
M chrome_frame/metrics_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/metrics_service.cc View 1 2 9 chunks +67 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
10 years, 3 months ago (2010-09-15 03:13:57 UTC) #1
amit
10 years, 3 months ago (2010-09-15 21:12:04 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698