Issue 3396004: GTK: If the user hovers over stop, it should be disabled once page has finished loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3396004: GTK: If the user hovers over stop, it should be disabled once page has finished loading. (Closed)

Created:
10 years, 3 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting, Evan Stade

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

GTK: If the user hovers over stop, it should be disabled once page has finished loading. This works in both chrome and gtk theme mode, though it uses different code paths (in chrome-theme mode, we override stop_.paint_state(), in gtk-theme mode, we force rendering of the stock icon to insensitive). We can't just set the widget to insensitive because changing the sensitivity of a widget immediately synthesizes a leave notification. BUG=46981 TEST=behaviour matches windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59515

Patch Set 1 #

Patch Set 2 : Fix for older gtk+ versions #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -8 lines)			Patch
	M	chrome/browser/gtk/reload_button_gtk.cc	View	1	4 chunks	+51 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

can you put more of the comments/messages in the change description? In particular the part ...

10 years, 3 months ago (2010-09-15 00:26:13 UTC) #2

Peter Kasting

10 years, 3 months ago (2010-09-15 17:18:59 UTC) #3

FYI, I'm on vacation until next week.  I'll assume estade's review is sufficient
for you.

Expand Messages | Collapse Messages