Add verify option to image_to_live.

Add verify option to image_to_live.

Change-Id: I63f7ce38179b713bb26bed70d6fd392425595a81

BUG=
TEST=Ran with update vm script.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3b65e8d

[kmixter1, 2010-09-23 20:56:30]

If you don't make this the default, could you add this to sync_build_test around
line 629 as well?

http://codereview.chromium.org/3393019/diff/2001/3002
File image_to_live.sh (right):

http://codereview.chromium.org/3393019/diff/2001/3002#newcode28
image_to_live.sh:28: DEFINE_boolean verify "${FLAGS_FALSE}" "Verify image on
device after update."
Since this is always an integer, you can remove the quotes (and above for
update).

http://codereview.chromium.org/3393019/diff/2001/3002#newcode284
image_to_live.sh:284: info "Image verified."
How about Update was successful and image verified as ${lsb_release}?

http://codereview.chromium.org/3393019/diff/2001/3002#newcode304
image_to_live.sh:304: die "Verify is not compatible with setting an update url."
It really seems like you want the default behavior to be the best check.  If you
want you could make it default on, then just issue a warning here and set
FLAGS_verify=${FLAGS_FALSE} if it's not possible.

http://codereview.chromium.org/3393019/diff/2001/3002#newcode345
image_to_live.sh:345: exit $?
It's set -e, so you could just get rid of this exit, an even get rid of the
other branch's exit and just return 0 like before.

[sosa, 2010-09-28 20:25:06]

Cleaned up.  Also added a flag to skip stateful_update to make testing easier.

Re-tested with cros_vm_update wrapper.

[sosa, 2010-09-28 20:26:21]

Actually publish comments this time

http://codereview.chromium.org/3393019/diff/2001/3002
File image_to_live.sh (right):

http://codereview.chromium.org/3393019/diff/2001/3002#newcode284
image_to_live.sh:284: info "Image verified."
On 2010/09/23 20:56:38, kmixter1 wrote:
> How about Update was successful and image verified as ${lsb_release}?

Done.

http://codereview.chromium.org/3393019/diff/2001/3002#newcode304
image_to_live.sh:304: die "Verify is not compatible with setting an update url."
Good call.  Changed to default.  

On 2010/09/23 20:56:38, kmixter1 wrote:
> It really seems like you want the default behavior to be the best check.  If
you
> want you could make it default on, then just issue a warning here and set
> FLAGS_verify=${FLAGS_FALSE} if it's not possible.

http://codereview.chromium.org/3393019/diff/2001/3002#newcode345
image_to_live.sh:345: exit $?
On 2010/09/23 20:56:38, kmixter1 wrote:
> It's set -e, so you could just get rid of this exit, an even get rid of the
> other branch's exit and just return 0 like before.

Done.

[kmixter1, 2010-09-28 20:59:21]

LGTM

On Tue, Sep 28, 2010 at 1:26 PM, <sosa@chromium.org> wrote:

> Actually publish comments this time
>
>
>
> http://codereview.chromium.org/3393019/diff/2001/3002
> File image_to_live.sh (right):
>
> http://codereview.chromium.org/3393019/diff/2001/3002#newcode284
> image_to_live.sh:284: info "Image verified."
> On 2010/09/23 20:56:38, kmixter1 wrote:
>
>> How about Update was successful and image verified as ${lsb_release}?
>>
>
> Done.
>
>
> http://codereview.chromium.org/3393019/diff/2001/3002#newcode304
> image_to_live.sh:304: die "Verify is not compatible with setting an
> update url."
> Good call.  Changed to default.
>
>
> On 2010/09/23 20:56:38, kmixter1 wrote:
>
>> It really seems like you want the default behavior to be the best
>>
> check.  If you
>
>> want you could make it default on, then just issue a warning here and
>>
> set
>
>> FLAGS_verify=${FLAGS_FALSE} if it's not possible.
>>
>
> http://codereview.chromium.org/3393019/diff/2001/3002#newcode345
> image_to_live.sh:345: exit $?
> On 2010/09/23 20:56:38, kmixter1 wrote:
>
>> It's set -e, so you could just get rid of this exit, an even get rid
>>
> of the
>
>> other branch's exit and just return 0 like before.
>>
>
> Done.
>
>
> http://codereview.chromium.org/3393019/show
>