Issue 3393013: Fix a bug where we would show both the apps and thumb sections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3393013: Fix a bug where we would show both the apps and thumb sections (Closed)

Created:
10 years, 3 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, Paweł Hajdan Jr., arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Fix a bug where we would show both the apps and thumb sections if both sections were shown under the old version of the ntp. Also clean up some old cruft. BUG=55610 TEST=Upgrade Chrome from an older version to a version with this change with at least one app installed. Should see only apps section. Do it with no apps installed, should see only MV section. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60216

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : whoops #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -51 lines)			Patch
M	chrome/browser/dom_ui/new_tab_ui.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/dom_ui/shown_sections_handler.h	View		1 chunk	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/dom_ui/shown_sections_handler.cc	View		4 chunks	+12 lines, -17 lines	0 comments	Download
M	chrome/browser/dom_ui/shown_sections_handler_unittest.cc	View	1 2	1 chunk	+16 lines, -21 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.html	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/ntp/apps.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages