Issue 3391026: Remove sleep_timeout from TestTimeouts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3391026: Remove sleep_timeout from TestTimeouts. (Closed)

Created:
10 years, 2 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
huanr, Evan Martin

CC:
chromium-reviews

Visibility:
Public.

Description

Remove sleep_timeout from TestTimeouts. This still preserves the compatibility part in ui_test.h. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60764

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -13 lines)			Patch
M	chrome/test/test_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/test_switches.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/test_timeouts.h	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	chrome/test/test_timeouts.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/test/ui/ui_test.h	View	1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

This change might be still risky. Note that different handling of command-line flags.

10 years, 2 months ago (2010-09-27 10:16:51 UTC) #1

Evan Martin

LGTM http://codereview.chromium.org/3391026/diff/1/6 File chrome/test/ui/ui_test.h (right): http://codereview.chromium.org/3391026/diff/1/6#newcode378 chrome/test/ui/ui_test.h:378: return TestTimeouts::action_timeout_ms(); Do we ever use flags to ...

10 years, 2 months ago (2010-09-27 16:15:01 UTC) #2

Paweł Hajdan Jr.

10 years, 2 months ago (2010-09-28 08:59:15 UTC) #4

On 2010/09/27 16:15:01, Evan Martin wrote:
> Do we ever use flags to adjust sleep_timeout_ms != action_timeout_ms?

I'm not sure. That's why I'm removing it in small steps.

Expand Messages | Collapse Messages