Issue 3391011: Map: Guard concurrent accesses to a std::map by a lock in drawing code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3391011: Map: Guard concurrent accesses to a std::map by a lock in drawing code. (Closed)

Created:
10 years, 3 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit), stuartmorgan, pink (ping after 24hrs)

CC:
chromium-reviews, darin-cc_chromium.org, ben+cc_chromium.org, pam+watch_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Description

Map: Guard concurrent accesses to a std::map by a lock in drawing code. Both UI thread and displaylink thread always take the CG lock before taking this new lock, hence this shouldn't deadlock (the UI thread sometimes only takes and releases the new lock without attempting to take the CG lock). BUG=52491 TEST=no more crashes in DrawAcceleratedSurfaceInstace Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59890

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
	M	chrome/browser/renderer_host/accelerated_surface_container_manager_mac.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
	M	chrome/browser/renderer_host/accelerated_surface_container_manager_mac.cc	View		9 chunks	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages