Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 3391007: Add autotests to check that the IME works. (Closed)

Created:
10 years, 3 months ago by Zachary Kuznia
Modified:
9 years, 7 months ago
Reviewers:
Yusuke Sato
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org
Visibility:
Public.

Description

Add autotests to check that the IME works. - Check that ibus-daemon launches when an IME is added. - Check that ibus-daemon is killed when all IMEs are removed. - Check that you can enable and enter text in mozc, chewing, hangul and pinyin Change-Id: I389affd635685ef8387fad713fe63d8d45ee49df BUG=chromium-os:4639 TEST=Run the desktopui_ImeTest autotest Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=74144b2

Patch Set 1 #

Patch Set 2 : Code Review #

Patch Set 3 : Improve Comments #

Patch Set 4 : Replace utf8 characters with escape codes #

Total comments: 4

Patch Set 5 : Comment the sleeps. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -0 lines) Patch
A client/site_tests/desktopui_ImeTest/control View 1 chunk +21 lines, -0 lines 0 comments Download
A client/site_tests/desktopui_ImeTest/desktopui_ImeTest.py View 1 2 3 4 1 chunk +147 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Zachary Kuznia
10 years, 3 months ago (2010-09-17 06:05:41 UTC) #1
Yusuke Sato
LGTM http://codereview.chromium.org/3391007/diff/7001/8002 File client/site_tests/desktopui_ImeTest/desktopui_ImeTest.py (right): http://codereview.chromium.org/3391007/diff/7001/8002#newcode48 client/site_tests/desktopui_ImeTest/desktopui_ImeTest.py:48: time.sleep(3) can you add a comment to explain ...
10 years, 3 months ago (2010-09-17 08:08:09 UTC) #2
ericli
Any chance you could help to add this into nightly control suite? Thanks. Eric On ...
10 years, 3 months ago (2010-09-18 22:08:32 UTC) #3
Zachary Kuznia
Certainly! Where would I find the docs on this? On 2010/09/18 22:08:32, ericli wrote: > ...
10 years, 3 months ago (2010-09-21 01:11:20 UTC) #4
Zachary Kuznia
10 years, 3 months ago (2010-09-21 01:17:27 UTC) #5
http://codereview.chromium.org/3391007/diff/7001/8002
File client/site_tests/desktopui_ImeTest/desktopui_ImeTest.py (right):

http://codereview.chromium.org/3391007/diff/7001/8002#newcode48
client/site_tests/desktopui_ImeTest/desktopui_ImeTest.py:48: time.sleep(3)
On 2010/09/17 08:08:14, Yusuke Sato wrote:
> can you add a comment to explain why sleep() is necessary here?

Done.

http://codereview.chromium.org/3391007/diff/7001/8002#newcode67
client/site_tests/desktopui_ImeTest/desktopui_ImeTest.py:67: time.sleep(1)
On 2010/09/17 08:08:14, Yusuke Sato wrote:
> ditto.

Done.

Powered by Google App Engine
This is Rietveld 408576698