Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 339095: DeferredAutoreleasePool didn't work on Snow Leopard (Closed)

Created:
11 years, 1 month ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
dmac
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, jam, pam+watch_chromium.org, darin (slow to review)
Visibility:
Public.

Description

DeferredAutoreleasePool didn't work on Snow Leopard. This is a backout of r30647, but also resurrects the change from http://codereview.chromium.org/341022 to work around the crash that r30647 solved much more elegantly. We can't really leave things broken on 10.6, though. I killed most of a perfectly good Friday evening trying to figure out how to salvage r30647, but the DeferredAutoreleasePool approach seems doomed without making private calls. This makes me really sad. BUG=25857, 26399, 26402 TEST=Does it launch on Snow Leopard now? Does it crash when you close windows? Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -297 lines) Patch
M base/message_pump_mac.h View 5 chunks +1 line, -38 lines 0 comments Download
M base/message_pump_mac.mm View 10 chunks +31 lines, -252 lines 0 comments Download
M chrome/browser/cocoa/browser_window_controller.mm View 2 chunks +16 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 5 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
Normally "doesn't launch on 10.6" would be cause for an immediate TBR backout, but it's ...
11 years, 1 month ago (2009-10-31 04:57:06 UTC) #1
Mark Mentovai
I committed this backout TBR to not frustrate people who might want to develop on ...
11 years, 1 month ago (2009-10-31 15:35:43 UTC) #2
dmac
11 years, 1 month ago (2009-11-02 22:50:03 UTC) #3
On 2009/10/31 15:35:43, Mark Mentovai wrote:
> I committed this backout TBR to not frustrate people who might want to develop
> on 10.6 over the weekend.

LGTM... sigh.

Powered by Google App Engine
This is Rietveld 408576698