Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: build/common.gypi

Issue 339079: linux: fix library=shared_library issues (Closed)
Patch Set: . Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | chrome/chrome.gyp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 'variables': { 9 'variables': {
10 # .gyp files should set chromium_code to 1 if they build Chromium-specific 10 # .gyp files should set chromium_code to 1 if they build Chromium-specific
(...skipping 654 matching lines...) Expand 10 before | Expand all | Expand 10 after
665 ], 665 ],
666 }], 666 }],
667 ['linux_breakpad==1', { 667 ['linux_breakpad==1', {
668 'cflags': [ '-gstabs' ], 668 'cflags': [ '-gstabs' ],
669 'defines': ['USE_LINUX_BREAKPAD'], 669 'defines': ['USE_LINUX_BREAKPAD'],
670 }], 670 }],
671 ['library=="shared_library"', { 671 ['library=="shared_library"', {
672 # When building with shared libraries, remove the visiblity-hiding 672 # When building with shared libraries, remove the visiblity-hiding
673 # flag. 673 # flag.
674 'cflags!': [ '-fvisibility=hidden' ], 674 'cflags!': [ '-fvisibility=hidden' ],
675 'conditions': [
676 ['target_arch=="x64"', {
677 # Shared libraries need -fPIC on x86-64
678 'cflags': ['-fPIC']
679 }]
680 ],
675 }], 681 }],
676 ], 682 ],
677 }, 683 },
678 }], 684 }],
679 ['OS=="mac"', { 685 ['OS=="mac"', {
680 'target_defaults': { 686 'target_defaults': {
681 'variables': { 687 'variables': {
682 # This should be 'mac_real_dsym%', but there seems to be a bug 688 # This should be 'mac_real_dsym%', but there seems to be a bug
683 # with % in variables that are intended to be set to different 689 # with % in variables that are intended to be set to different
684 # values in different targets, like this one. 690 # values in different targets, like this one.
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
908 # and therefore SYMROOT, needs to be set at the project level. 914 # and therefore SYMROOT, needs to be set at the project level.
909 'SYMROOT': '<(DEPTH)/xcodebuild', 915 'SYMROOT': '<(DEPTH)/xcodebuild',
910 }, 916 },
911 } 917 }
912 918
913 # Local Variables: 919 # Local Variables:
914 # tab-width:2 920 # tab-width:2
915 # indent-tabs-mode:nil 921 # indent-tabs-mode:nil
916 # End: 922 # End:
917 # vim: set expandtab tabstop=2 shiftwidth=2: 923 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | chrome/chrome.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698