Issue 339078: Convert chrome_url_data_manager (previously a global) into a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339078: Convert chrome_url_data_manager (previously a global) into a (Closed)

Created:
11 years, 1 month ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Convert chrome_url_data_manager (previously a global) into a Singleton. This is just cleanup. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30594

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -31 lines)			Patch
M	chrome/browser/browser_about_handler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/dom_ui/chrome_url_data_manager.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/dom_ui/chrome_url_data_manager.cc	View	9 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/dom_ui/downloads_dom_handler.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/downloads_ui.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/dom_ui/filebrowse_ui.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/dom_ui/history_ui.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/dom_ui/most_visited_handler.cc	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/dom_ui/new_tab_ui.cc	View	4 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/dom_ui/print_ui.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extensions_ui.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Looks ugly to me rubber stamp.