Issue 339077: Need to load the permissions lists every time at startup for notifications....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339077: Need to load the permissions lists every time at startup for notifications.... (Closed)

Created:
11 years, 1 month ago by John Gregg

Modified:
9 years ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Need to load the permissions lists every time at startup for notifications. BUG=26274 TEST=grant notifications permissions and restart browser Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30623

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -12 lines)			Patch
M	chrome/browser/notifications/desktop_notification_service.cc	View	1 chunk	+6 lines, -10 lines	0 comments	Download
M	chrome/browser/notifications/notifications_prefs_cache.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/notifications/notifications_prefs_cache.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

11 years, 1 month ago (2009-10-30 19:06:32 UTC) #2

LGTM

My only concern is what I expressed earlier - perhaps we should *always* call
RegisterListPref(), so you should ask someone more familiar with the API to make
sure you're using the right idiom.

Expand Messages | Collapse Messages