Issue 339076: The newly added AboutChromeFrame test for IE full tab mode was failing on the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339076: The newly added AboutChromeFrame test for IE full tab mode was failing on the... (Closed)

Created:
11 years, 1 month ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
stoyan

CC:
chromium-reviews_googlegroups.com, darin (slow to review), amit, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

The newly added AboutChromeFrame test for IE full tab mode was failing on the chrome frame builder which is an XP machine with IE8 (It was not supposed to return on IE8 :) The reason being that the VK_UP keyboard message we were passing in via SendInput needs the extended flag to be true. I added the extended flag as an argument to the SendVirtualKey helper function. On a related note, I removed the GetIEVersion check from the utility function which launches IE as a COM server as the IE version checking function checks the version of the current module and compares it against IE versions which is hilarious. In any case these tests work fine. TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30549

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -14 lines)			Patch
M	chrome_frame/test/chrome_frame_test_utils.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome_frame/test/chrome_frame_test_utils.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome_frame/test/chrome_frame_unittests.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome_frame/test/net/dialog_watchdog.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages