Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10225)

Unified Diff: chrome/renderer/webplugin_delegate_proxy.cc

Issue 339068: Try to force plugins to use software rendering until we can support... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/webplugin_delegate_proxy.cc
===================================================================
--- chrome/renderer/webplugin_delegate_proxy.cc (revision 30454)
+++ chrome/renderer/webplugin_delegate_proxy.cc (working copy)
@@ -273,6 +273,16 @@
transparent_ = true;
}
}
+#if defined(OS_MACOSX)
+ // Until we have a way to support accelerated (3D) drawing on Macs, ask
+ // Flash to use windowless mode so that it use CoreGraphics instead of opening
+ // OpenGL contexts overlaying the browser window (which will fail or crash
+ // because Mac OS X does not allow that across processes).
+ if (!transparent_ && mime_type_ == "application/x-shockwave-flash" ) {
darin (slow to review) 2009/10/29 19:54:24 nit: extra space there at the end
Amanda Walker 2009/10/29 20:08:14 Oops, missed that before committing. Will fix.
+ params.arg_names.push_back("wmode");
+ params.arg_values.push_back("opaque");
+ }
+#endif
params.load_manually = load_manually;
plugin_ = plugin;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698