Add compiler-specific "examine printf format" attributes to printfs.

chrome/common/extensions/extension_unittest.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "chrome/common/extensions/extension.h"
+
+#include "base/format_macros.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/string_util.h"
 #include "base/path_service.h"
 #include "chrome/common/chrome_paths.h"
-#include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_error_reporter.h"
 #include "chrome/common/json_value_serializer.h"
 #include "net/base/mime_sniffer.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace keys = extension_manifest_keys;
 namespace values = extension_manifest_values;
 namespace errors = extension_manifest_errors;
 
@@ skipping 433 matching lines @@
   valid.push_back("http://test.com");
   valid.push_back("http://test.com/");
   valid.push_back("http://test.com/update");
   valid.push_back("http://test.com/update?check=true");
   for (size_t i = 0; i < valid.size(); i++) {
     GURL url(valid[i]);
     EXPECT_TRUE(url.is_valid());
 
     DictionaryValue input_value;
 #if defined(OS_WIN)
-    FilePath path(StringPrintf(L"c:\\extension%i", i));
+    // (Why %d below?  This is the single place in the whole code base that
+    // might make use of a WidePRIuS; let's not encourage any more.)

[Mark Mentovai, 2009/11/18 20:55:27]

OK, that's fair enough.  But wouldn't it be L"%Iu" for a size_t on Windows
instead of L"%d"?

+    FilePath path(StringPrintf(L"c:\\extension%d", i));
 #else
-    FilePath path(StringPrintf("/extension%i", i));
+    FilePath path(StringPrintf("/extension%" PRIuS, i));
 #endif
     Extension extension(path);
     std::string error;
 
     input_value.SetString(keys::kVersion, "1.0");
     input_value.SetString(keys::kName, "Test");
     input_value.SetString(keys::kUpdateURL, url.spec());
 
     EXPECT_TRUE(extension.InitFromValue(input_value, false, &error));
   }
 
   // Test some invalid update urls
   std::vector<std::string> invalid;
   invalid.push_back("");
   invalid.push_back("test.com");
   valid.push_back("http://test.com/update#whatever");
   for (size_t i = 0; i < invalid.size(); i++) {
     DictionaryValue input_value;
 #if defined(OS_WIN)
-    FilePath path(StringPrintf(L"c:\\extension%i", i));
+    // We should use PRIuS here, but it's a wide string.  This is the only
+    // instance of a wide string needing PRIuS in the entire code base, so
+    // let's just work around it here.

[Mark Mentovai, 2009/11/18 20:55:27]

Same.

Oh, I guess there are two locations...

+    FilePath path(StringPrintf(L"c:\\extension%d", i));
 #else
-    FilePath path(StringPrintf("/extension%i", i));
+    FilePath path(StringPrintf("/extension%" PRIuS, i));
 #endif
     Extension extension(path);
     std::string error;
     input_value.SetString(keys::kVersion, "1.0");
     input_value.SetString(keys::kName, "Test");
     input_value.SetString(keys::kUpdateURL, invalid[i]);
 
     EXPECT_FALSE(extension.InitFromValue(input_value, false, &error));
     EXPECT_TRUE(MatchPattern(error, errors::kInvalidUpdateURL));
   }
@@ skipping 156 matching lines @@
     scoped_ptr<Extension> new_extension(
         LoadManifest("allow_silent_upgrade",
                      std::string(kTests[i].base_name) + "_new.json"));
 
     EXPECT_EQ(kTests[i].expect_success,
               Extension::IsPrivilegeIncrease(old_extension.get(),
                                              new_extension.get()))
         << kTests[i].base_name;
   }
 }