chrome/browser/extensions/extensions_service.cc - Issue 339058: Removes fallback from Prefs to LoadExtension on UI thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extensions_service.cc

Issue 339058: Removes fallback from Prefs to LoadExtension on UI thread (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extensions_service.cc

===================================================================

--- chrome/browser/extensions/extensions_service.cc (revision 30464)

+++ chrome/browser/extensions/extensions_service.cc (working copy)

@@ -21,6 +21,7 @@

#include "chrome/browser/net/chrome_url_request_context.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension.h"

+#include "chrome/common/extensions/extension_constants.h"

#include "chrome/common/extensions/extension_error_reporter.h"

#include "chrome/common/notification_service.h"

#include "chrome/common/pref_names.h"

@@ -280,11 +281,7 @@

extension = tmp.release();

}

} else {

- // TODO(mpcomplete): obsolete. remove after migration period.

- // http://code.google.com/p/chromium/issues/detail?id=19733

- extension = extension_file_util::LoadExtension(path,

- true, // Require id

- &error);

+ error = extension_manifest_errors::kManifestUnreadable;

}

if (!extension) {

« no previous file with comments | « no previous file | chrome/browser/extensions/extensions_service_unittest.cc » ('j') | no next file with comments »