Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 339057: Fix for GL unit_tests.... (Closed)

Created:
11 years, 1 month ago by gman
Modified:
9 years, 7 months ago
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

Fix for GL unit_tests. Apparently there are issues with making a window off screen. We were creating a 512/512 window -1000 pixels off the screen. This worked before but recently it stopped working on my (gman) machine. I checked by building the release build 0.1.42.3 and that version fails as well where as it used to work. I don't know what changed on my machine. Also added CS_OWNDC in several places. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30413

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M command_buffer/service/cross/gl/gapi_gl.cc View 1 chunk +1 line, -1 line 0 comments Download
M core/cross/gl/renderer_gl.cc View 1 chunk +1 line, -1 line 0 comments Download
M tests/common/win/testing_common.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gman
11 years, 1 month ago (2009-10-29 00:30:24 UTC) #1
gman
11 years, 1 month ago (2009-10-29 00:34:21 UTC) #2
Ken Russell (Google)
11 years, 1 month ago (2009-10-29 00:36:50 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698