Hoist bug reporting code out of bug_report_view so that it can be used cross-...

Hoist bug reporting code out of bug_report_view so that it can be used cross-platform.

BUG= none
TEST= bug reporting should work the same on Windows.

[Miranda Callahan, 2009-10-28 21:30:18]

Oops -- just fixed the linux build break in patch set 3.

On 2009/10/28 21:24:31, Miranda Callahan wrote:
>

[Amanda Walker, 2009-10-28 21:30:47]

LGTM with 2 changes.

http://codereview.chromium.org/339051/diff/4001/5002
File chrome/browser/bug_report_util.cc (right):

http://codereview.chromium.org/339051/diff/4001/5002#newcode74
Line 74: #endif
Add a TODO (and/or file a bug) to add Linux and Mac implementations of this
method.  I'd also have it return "unknown" for any OS where we're not fetching
the version (see next comment).

http://codereview.chromium.org/339051/diff/4001/5002#newcode154
Line 154: #endif
If we return "unknown" above for OSs that we haven't implemented yet, we can
take out the #if (and make the report data more uniform across OSs as well).

[Miranda Callahan, 2009-10-28 22:10:54]

Thanks -- fixed.  Will wait until tomorrow to commit in case there are
drive-bys.

On 2009/10/28 21:30:47, Amanda Walker wrote:
> LGTM with 2 changes.
> 
> http://codereview.chromium.org/339051/diff/4001/5002
> File chrome/browser/bug_report_util.cc (right):
> 
> http://codereview.chromium.org/339051/diff/4001/5002#newcode74
> Line 74: #endif
> Add a TODO (and/or file a bug) to add Linux and Mac implementations of this
> method.  I'd also have it return "unknown" for any OS where we're not fetching
> the version (see next comment).
> 
> http://codereview.chromium.org/339051/diff/4001/5002#newcode154
> Line 154: #endif
> If we return "unknown" above for OSs that we haven't implemented yet, we can
> take out the #if (and make the report data more uniform across OSs as well).

[Miranda Callahan, 2009-10-28 22:10:59]

http://codereview.chromium.org/339051/diff/4001/5002
File chrome/browser/bug_report_util.cc (right):

http://codereview.chromium.org/339051/diff/4001/5002#newcode74
Line 74: #endif
On 2009/10/28 21:30:47, Amanda Walker wrote:
> Add a TODO (and/or file a bug) to add Linux and Mac implementations of this
> method.  I'd also have it return "unknown" for any OS where we're not fetching
> the version (see next comment).

Done.

http://codereview.chromium.org/339051/diff/4001/5002#newcode154
Line 154: #endif
On 2009/10/28 21:30:47, Amanda Walker wrote:
> If we return "unknown" above for OSs that we haven't implemented yet, we can
> take out the #if (and make the report data more uniform across OSs as well).
> 

Done.