Move console stack dumping code to a function so it can be reused in test_she...

Move console stack dumping code to a function so it can be reused in test_shell_tests.

TEST=none
BUG=13770
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30220

[M-A Ruel, 2009-10-27 13:51:25]

The main issue atm is that run_webkit_tests redirects test_shell's output to
/dev/null so even if it prints a stack trace, it won't be seen.

Any thought on this?

http://codereview.chromium.org/339024/diff/1/4
File base/process_util.h (right):

http://codereview.chromium.org/339024/diff/1/4#newcode427
Line 427: #if defined(UNIT_TEST)
I don't want this function called outside unit tests.

[M-A Ruel, 2009-10-27 14:46:50]

http://codereview.chromium.org/339024/diff/3001/4006
File webkit/tools/test_shell/test_shell_main.cc (right):

http://codereview.chromium.org/339024/diff/3001/4006#newcode6
Line 6: #define UNIT_TEST
Actually, I'm not sure about adding the define to GYP. Any opinion?

[ojan, 2009-10-27 16:29:36]

LGTM

I'm happy to modify run_webkit_tests once this code is in.

http://codereview.chromium.org/339024/diff/3001/4002
File base/process_util_posix.cc (right):

http://codereview.chromium.org/339024/diff/3001/4002#newcode60
Line 60: static const int64 kQuarterSecondInMicroseconds =
kMicrosecondsPerSecond/4;
Nit: spaces around the /.

http://codereview.chromium.org/339024/diff/3001/4005
File base/process_util_win.cc (right):

http://codereview.chromium.org/339024/diff/3001/4005#newcode792
Line 792: void AttachToConsole() {
Since this is only used one windows, maybe just inline it into
EnableInProcessStackDumping?

http://codereview.chromium.org/339024/diff/3001/4006
File webkit/tools/test_shell/test_shell_main.cc (right):

http://codereview.chromium.org/339024/diff/3001/4006#newcode6
Line 6: #define UNIT_TEST
On 2009/10/27 14:46:50, Marc-Antoine Ruel wrote:
> Actually, I'm not sure about adding the define to GYP. Any opinion?

I don't have a strong opinion. Keeping the defines in one place (i.e. gyp) makes
sense to me though.

[M-A Ruel, 2009-10-27 17:26:38]

I've moved things around if you want to take a look.