Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 339019: Change the document root for the test Web Socket server to WebKit/LayoutTests... (Closed)

Created:
11 years, 1 month ago by Yuzo
Modified:
9 years, 7 months ago
Reviewers:
ukai
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org, tyoshino (SeeGerritForStatus)
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Change the document root for the test Web Socket server to WebKit/LayoutTests from WebKit/LayoutTests/websocket/tests. This makes reusing scripts in WebKit/LayoutTests/fast/js/resources easier. For example, a test in WebKit/LayoutTests/websocket/tests/sample.html can include js-test-pre.js as ../../fast/js/resources/js-test-pre.js. TEST=none BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M webkit/tools/layout_tests/layout_package/path_utils.py View 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/tools/layout_tests/layout_package/websocket_server.py View 7 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yuzo
Hi, Ukai-san, Can you review this? Yuzo
11 years, 1 month ago (2009-10-27 05:56:41 UTC) #1
Yuzo
Ping?
11 years, 1 month ago (2009-10-28 10:46:44 UTC) #2
ukai
LGTM.
11 years, 1 month ago (2009-10-29 10:42:55 UTC) #3
Yuzo
11 years, 1 month ago (2009-10-30 01:34:47 UTC) #4
Landed as r30548.

Powered by Google App Engine
This is Rietveld 408576698