Loosen RFC 1738 compliance check to allow underscores where we already allowe...

net/base/net_util.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_NET_UTIL_H_
 #define NET_BASE_NET_UTIL_H_
 
 #include "build/build_config.h"
 
 #ifdef OS_WIN
@@ skipping 140 matching lines @@
                   const std::wstring& languages,
                   std::wstring* out);
 
 // Canonicalizes |host| and returns it.  Also fills |host_info| with
 // IP address information.  |host_info| must not be NULL.
 std::string CanonicalizeHost(const std::string& host,
                              url_canon::CanonHostInfo* host_info);
 std::string CanonicalizeHost(const std::wstring& host,
                              url_canon::CanonHostInfo* host_info);
 
-// Returns true if |host| is RFC 1738-compliant (and not an IP address).  The
-// rules are:
+// Returns true if |host| is not an IP address and is compliant with a set of
+// rules based on RFC 1738 and tweaked to be compatible with the real world.
+// The rules are:
 //   * One or more components separated by '.'
 //   * Each component begins and ends with an alphanumeric character
-//   * Each component contains only alphanumeric characters and '-'
+//   * Each component contains only alphanumeric characters and '-' or '_'
 //   * The last component does not begin with a digit
 //
 // NOTE: You should only pass in hosts that have been returned from
 // CanonicalizeHost(), or you may not get accurate results.
-bool IsCanonicalizedHostRFC1738Compliant(const std::string& host);
+bool IsCanonicalizedHostCompliant(const std::string& host);
 
 // Call these functions to get the html snippet for a directory listing.
 // The return values of both functions are in UTF-8.
 std::string GetDirectoryListingHeader(const string16& title);
 
 // Given the name of a file in a directory (ftp or local) and
 // other information (is_dir, size, modification time), it returns
 // the html snippet to add the entry for the file to the directory listing.
 // Currently, it's a script tag containing a call to a Javascript function
 // |addRow|.
@@ skipping 75 matching lines @@
 // Strip the portions of |url| that aren't core to the network request.
 //   - user name / password
 //   - reference section
 GURL SimplifyUrlForRequest(const GURL& url);
 
 void SetExplicitlyAllowedPorts(const std::wstring& allowed_ports);
 
 }  // namespace net
 
 #endif  // NET_BASE_NET_UTIL_H_