Issue 339016: Renames addItemToTimeline to addRecordToTimeline due to WebKit...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339016: Renames addItemToTimeline to addRecordToTimeline due to WebKit... (Closed)

Created:
11 years, 1 month ago by Kelly Norton

Modified:
9 years, 7 months ago

Reviewers:
pfeldman

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Renames addItemToTimeline to addRecordToTimeline due to WebKit change: https://bugs.webkit.org/show_bug.cgi?id=30785 Patch by: Kelly Norton (knorton@google.com) TEST=create extension, register for events, verify that they fire BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30236

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	webkit/glue/devtools/js/inject_dispatch.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Kelly Norton

Since this is just a string comparison it doesn't matter if this goes in before ...

11 years, 1 month ago (2009-10-26 23:00:12 UTC) #1

Kelly Norton

11 years, 1 month ago (2009-10-27 14:33:16 UTC) #3

Thanks Pavel, Can you land this for me when you get a spare moment?