Issue 339013: cros: doing dbus stuff on the file thread==disaster.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339013: cros: doing dbus stuff on the file thread==disaster. (Closed)

Created:
11 years, 1 month ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

cros: doing dbus stuff on the file thread==disaster. libdbus-glib uses the glib main loop internally. We were making calls on a background thread that wound up telling libdbus-glib to get a connection to the system bus on said background thread. This led to a background thread trying to use the same glib main loop as Chrome's UI thread, and concurrency issues led to crashing. Sadly, there can be only one main loop per process, as I understand it. This code takes away the attempts to use the background thread. As our interaction with dbus is semantically asynchronous, this seems ok to me. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30135

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -28 lines)			Patch
M	chrome/browser/chromeos/cros_network_library.h	View	5 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/cros_network_library.cc	View	3 chunks	+13 lines, -15 lines	0 comments	Download
M	chrome/browser/chromeos/cros_power_library.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/cros_power_library.cc	View	2 chunks	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages