Issue 339007: Fix support for builds from build/ directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 339007: Fix support for builds from build/ directory. (Closed)

Created:
11 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix support for builds from build/ directory. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30184

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	webkit/tools/layout_tests/layout_package/platform_utils_win.py	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

It's more a hack than anything else but the "exception way" of finding paths makes ...

11 years, 1 month ago (2009-10-26 19:47:38 UTC) #1

Dirk Pranke

On 2009/10/26 19:47:38, Marc-Antoine Ruel wrote: > It's more a hack than anything else but ...

11 years, 1 month ago (2009-10-26 22:52:47 UTC) #2

M-A Ruel

11 years, 1 month ago (2009-10-26 23:42:55 UTC) #3

On 2009/10/26 22:52:47, dpranke wrote:
> On 2009/10/26 19:47:38, Marc-Antoine Ruel wrote:
> > It's more a hack than anything else but the "exception way" of finding paths
> > makes it hard to use a better way.
> 
> Looks good to me; on the other hand, I think the fact that we have two
different
> build dirs is probably no longer necessary, and I'd be happy to change the
whole
> system. Don't suppose you want to take that on?

Eventually, it's not a huge priority as in "we don't have a bug filed for that
yet".

Expand Messages | Collapse Messages